fix!: use bun as package manager when bun.lock is found #5962
Conversation
pieh
force-pushed
the
michalpiechowiak/frb-1544-bunlock-not-selecting-bun-bunlockb-works
branch
from
9076d8d to
c733148
Compare
pieh
force-pushed
the
michalpiechowiak/frb-1544-bunlock-not-selecting-bun-bunlockb-works
branch
from
c733148 to
e106db4
Compare
pieh
changed the title
| /** The lock file a package manager is using */ | ||
| lockFile: string | ||
| /** The lock files a package manager is using */ | ||
| lockFiles: string[] |
There was a problem hiding this comment.
We could potentially opt to support both fields for a short period of time while calling the old one deprecated (maybe raise a warning message in the logs?). That way we can understand the scope of affected systems before we look to drop the field.
There was a problem hiding this comment.
There is limited number of things using @netlify/build-info directly, so I think we can skip on interim period - this package is not meant for public consumption per-se as it's quite Netlify specific, so I don't think it warrants extra effort to have a ~deprecation period. Instead maybe we just have a canary with this change that we adjust consumers of this package before we merge and publish this change so we can minimize "package upgrade downtime"
There was a problem hiding this comment.
Published ~canary https://github.com/netlify/build/releases/tag/build-info-v8.0.0-pre-20250103.0.0 for testing (yikes with preid with double .0 there :D I definitely held https://github.com/netlify/build/blob/main/.github/workflows/pre-release.yml wrong hehe )
…ing-bun-bunlockb-works
pieh
deleted the
michalpiechowiak/frb-1544-bunlock-not-selecting-bun-bunlockb-works
branch
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://linear.app/netlify/issue/FRB-1544/bunlock-not-selecting-bun-bunlockb-works
This is a BREAKING CHANGE as it changes the shape of public API
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
BEGIN_COMMIT_OVERRIDE
fix: use bun as package manager when bun.lock is found
BREAKING CHANGE: packageManager.lockFile field containing single name of lock file is removed from output and packageManager.lockFiles field with array of possible lock files is introduced
END_COMMIT_OVERRIDE